To date, research on the long-term effects of childhood participation in voucher-assisted and public housing has been limited by the lack of data and suitable identification strategies. We create a national level longitudinal data set that enables us to analyze how children’s housing experiences affect adult earnings and incarceration rates. While naive estimates suggest there are substantial negative consequences to childhood participation in voucher assisted and public housing, this result appears to be driven largely by selection of households into housing assistance programs. To mitigate this source of bias, we employ household fixed-effects specifications that use only within-household (across-sibling) variation for identification. Compared to naive specifications, household fixed-effects estimates for earnings are universally more positive, and they suggest that there are positive and statistically significant benefits from childhood residence in assisted housing on young adult earnings for nearly all demographic groups. Childhood participation in assisted housing also reduces the likelihood of incarceration across all household race/ethnicity groups. Time spent in voucher-assisted or public housing is especially beneficial for females from non-Hispanic Black households, who experience substantial increases in expected earnings and lower incarceration rates.